Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check CLI versions if there is a known minimum version #530

Closed
trgill opened this issue Aug 10, 2017 · 4 comments
Closed

Check CLI versions if there is a known minimum version #530

trgill opened this issue Aug 10, 2017 · 4 comments
Assignees

Comments

@trgill
Copy link
Contributor

trgill commented Aug 10, 2017

Although we try to avoid invoking CLI tools from Stratis, there are some cases it is needed (XFS, thin provisioning).

Given we've got a known problem with "thin_check" version 2.8 or lower - should we adopt a strategy for a baseline on CLIs?

@trgill trgill changed the title should Stratis check CLI versions if there is a known minimum version should Stratis check CLI versions if there is a known minimum version? Aug 10, 2017
@agrover
Copy link
Contributor

agrover commented Aug 10, 2017

If we document a minimum required version (which we should, prominently), this is the sort of thing that distro packaging scripts would typically enforce.

But, I still am of the opinion this is still worth doing, since developers and do-it-yourselfers won't be using a distro-packaged Stratis, and the consequences for using a too-old version are that it certainly won't be a tested configuration, and we can't guarantee there won't be data loss.

@mulkieran
Copy link
Member

Our first step should be to reduce the places where we use Command to a very small set, even if it can't be empty.

@mulkieran
Copy link
Member

Does libblockdev allow client to specify the version of a command-line tool that libblockdev wraps that it requires? Most likely not, although I haven't checked.

@agrover agrover added this to the Version 1.0 milestone Mar 14, 2018
@agrover agrover changed the title should Stratis check CLI versions if there is a known minimum version? Check CLI versions if there is a known minimum version Mar 15, 2018
@mulkieran mulkieran self-assigned this Jun 13, 2018
@agrover agrover modified the milestones: Stratis 1.0, Stratis 2.0 Jul 17, 2018
mulkieran added a commit to mulkieran/stratisd that referenced this issue May 13, 2020
Get rid of last mention of tox in .travis.yml file
@mulkieran mulkieran removed this from the Stratis 2.0 milestone May 26, 2021
mulkieran added a commit that referenced this issue Oct 24, 2021
Run all tests for lowest supported toolchain as well as for stable
@mulkieran
Copy link
Member

The minimum supported version doesn't always make sense to think about. For example, for #3511, we can support multiple versions, but have to make a choice about the options we pass depending on the version. So, we might as well close this as too generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants