Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stratis_cli_cert: add SysfsMonitor class #230

Merged
merged 1 commit into from
Nov 20, 2023
Merged

stratis_cli_cert: add SysfsMonitor class #230

merged 1 commit into from
Nov 20, 2023

Conversation

bgurney-rh
Copy link
Member

Related: #229

@bgurney-rh bgurney-rh self-assigned this Nov 17, 2023
mulkieran
mulkieran requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One refactoring request...should do exactly the same thing but with fewer local variables.

testlib/infra.py Outdated Show resolved Hide resolved
mulkieran
mulkieran requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more request, then I think this is done.

testlib/infra.py Outdated Show resolved Hide resolved
@bgurney-rh bgurney-rh force-pushed the stratiscli-verifysysfs branch from 7b408fc to 879045d Compare November 18, 2023 00:05
@bgurney-rh
Copy link
Member Author

Squashed into a single commit.

mulkieran
mulkieran requested changes Nov 18, 2023
View reviewed changes
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add --verify-sysfs argument parsing and related code to stratisd_cert.py as well, and then this is complete.

@bgurney-rh bgurney-rh marked this pull request as ready for review November 20, 2023 15:39
@bgurney-rh bgurney-rh force-pushed the stratiscli-verifysysfs branch from 78e7668 to 934ef5f Compare November 20, 2023 16:00
@bgurney-rh
Copy link
Member Author

Squashed into a single commit, and reworded commit message.

@mulkieran mulkieran merged commit cd1ecae into stratis-storage:master Nov 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mulkieran mulkieran mulkieran approved these changes

Assignees

@bgurney-rh bgurney-rh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgurney-rh @mulkieran