Handle unwrap when shutting down JDC server #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbesraa
force-pushed
the
2025-01-16-avoid-unwrap-jdc
branch
from
1d8516c to
cd958d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
=======================================
Coverage 19.08% 19.08%
=======================================
Files 166 166
Lines 11066 11066
=======================================
Hits 2112 2112
Misses 8954 8954
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jbesraa
force-pushed
the
2025-01-16-avoid-unwrap-jdc
branch
from
cd958d0 to
09b806d
Compare
|
Thanks @Shourya742, addressed your comments |
Shourya742
approved these changes
Jan 16, 2025
jbesraa
force-pushed
the
2025-01-16-avoid-unwrap-jdc
branch
from
09b806d to
073bcd2
Compare
|
Rebased without further changes |
plebhash
approved these changes
Jan 18, 2025
pavlenex
force-pushed
the
2025-01-16-avoid-unwrap-jdc
branch
from
073bcd2 to
8a6a41a
Compare
|
oops, looks like SemVer CI is going to force us to bump MAJOR on taking note on #1345 |
jbesraa
force-pushed
the
2025-01-16-avoid-unwrap-jdc
branch
from
8a6a41a to
6bbbd9b
Compare
Ha! |
yes, can we add a new commit bumping MAJOR on |
jbesraa
force-pushed
the
2025-01-16-avoid-unwrap-jdc
branch
3 times, most recently
from
91a2087 to
5fa3813
Compare
plebhash
reviewed
Jan 22, 2025
jbesraa
force-pushed
the
2025-01-16-avoid-unwrap-jdc
branch
2 times, most recently
from
02243ea to
151befc
Compare
plebhash
added
ready-to-be-merged
In practice we always keep all of our crates updated with latest code changes in all of other internal crates, so instead of maintaing the versioning of each one for internal use, this commit just links to the latest code in each crate. This would alllow us to catch errors that might appear in one crate but are originated in other. While this would sometimes require more work, this can save us error that previously would appear only in the release process. This approach fits the current directory/project structre, but if crates are moved outside of this repo, they should be linked to the published crate on crates.io.
..This should prevent the code from panicing if a signal to shutdown is sent the JDC server As a result, MAJOR is pumped for `roles-logic-sv2` crate as new property was added to public `Error` struct.
pavlenex
force-pushed
the
2025-01-16-avoid-unwrap-jdc
branch
from
151befc to
6deea02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit(9a35baa) resolves #1189
2nd and 3rd resolves #1351