Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context_getter signature does not offer passing Awaitable #3762

Open
alexey-pelykh opened this issue Jan 31, 2025 · 0 comments · May be fixed by #3763
Open

context_getter signature does not offer passing Awaitable #3762

alexey-pelykh opened this issue Jan 31, 2025 · 0 comments · May be fixed by #3763

Comments

@alexey-pelykh
Copy link

The context_getter is further passed to

strawberry/strawberry/fastapi/router.py

Line 70 in 7ba5928

..., Union[Optional[CustomContext], Awaitable[Optional[CustomContext]]]
so

strawberry/strawberry/fastapi/router.py

Line 128 in 7ba5928

context_getter: Optional[Callable[..., Optional[Context]]] = None,
should likely have the same signature
@alexey-pelykh alexey-pelykh linked a pull request Jan 31, 2025 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(fix) fastapi: context_getter signature to allow Awaitable alexey-pelykh/strawberry
1 participant
@alexey-pelykh