-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAK CHANGE]: remove legacy adopt existing configs #739
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: ericsyh <[email protected]>
@ericsyh:Thanks for your contribution. For this PR, do we need to update docs? |
shall we also remove all manifests related to this? |
@MarvinCai Yeah, sure. I missed it. Will update to remove manifests. |
Signed-off-by: ericsyh <[email protected]>
@MarvinCai PTAL 742b55d |
@ericsyh We may need to keep this part for a while as we have recently found that some customers are using these options. |
Signed-off-by: ericsyh [email protected]
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #820
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
Remove adopt existing configs.
Modifications
Remove adopt existing configs.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)