Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Patternfly v6 #1191

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Upgrade to Patternfly v6 #1191

wants to merge 6 commits into from

Conversation

hemahg
Copy link
Contributor

@hemahg hemahg commented Nov 7, 2024

Upgrade to Patternfly v6

@hemahg hemahg marked this pull request as draft November 7, 2024 13:52
@hemahg hemahg force-pushed the update-patternfly-6 branch from ccb4580 to 726cad9 Compare November 11, 2024 12:29
@MikeEdgar MikeEdgar linked an issue Nov 11, 2024 that may be closed by this pull request
@hemahg hemahg force-pushed the update-patternfly-6 branch 3 times, most recently from b30e874 to de5ce70 Compare November 15, 2024 10:37
@hemahg hemahg marked this pull request as ready for review November 15, 2024 11:05
@hemahg hemahg changed the title [WIP] Upgrade to Patternfly v6 Upgrade to Patternfly v6 Nov 15, 2024
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice @hemahg. Here are a few issues I've seen browsing around the app so far. Also, if it is simple, it might be a good option to allow a toggle for light/dark modes [1] like
image

[1] https://www.patternfly.org/developer-resources/dark-theme-handbook


Brokers heading shifted up and left. Also, the rebalance tab is missing and this image is for a managed Kafka with a CR.
image

Compared to Topics:
image


Same heading issue for an individual topic, and the selected tab isn't highlighted:
image


Partition tabs are transparent - scrolling the configuration is visible through the tabs:
image

@hemahg
Copy link
Contributor Author

hemahg commented Nov 18, 2024

1.Fixing the Navigation and Highlight Issues: The heading issue in the Topic and Broker tabs has been addressed.
2.Regarding the rebalance tab, I couldn't reproduce the missing tab issue.
Screenshot 2024-11-18 at 12 47 01 PM
3.In the latest PatternFly version, the navigation highlights in white if the page section background is gray PatternFly Horizontal Nav Demo. However, since the page section is white, tab changes aren't visually highlighted. The previously used component is now deprecated:

@MikeEdgar
Copy link
Member

Ignore what I said earlier about the missing rebalance tab - it was an issue with my configuration. Sorry for any confusion on that.

@MikeEdgar
Copy link
Member

In the latest PatternFly version, the navigation highlights in white if the page section background is gray PatternFly Horizontal Nav Demo. However, since the page section is white, tab changes aren't visually highlighted. The previously used component is now deprecated:

Got it. Maybe we can switch to using the tab component in the future [1]? Did we have a reason to use nav instead of tab here to begin with? cc: @riccardo-forina

[1] https://www.patternfly.org/components/tabs

@riccardo-forina
Copy link
Collaborator

At the time, the tabs were full client components that did not support the routing at all. We have a unique url tied to each tab that loads the new portion of data following the way next.js router works. So I couldn't use that. And the tabs weren't a great fit estically speaking.

Feel free to change them to whatever works better.

@MikeEdgar
Copy link
Member

Ok, I see what you mean. It looks like there is support in PF6 for "tabs linked to Nav elements". We can think about whether that makes sense for a future PR.

https://www.patternfly.org/components/tabs#tabs-linked-to-nav-elements

@riccardo-forina
Copy link
Collaborator

That option was already available, but it renders plain html links, not Next Link components, unfortunately.

I suppose we could still use that, and add an onClick handler that triggers the react navigation programmatically preventing the default behavior. Not ideal, but workable I suppose

@hemahg hemahg force-pushed the update-patternfly-6 branch from 5116446 to 302818d Compare November 19, 2024 12:37
@MikeEdgar MikeEdgar marked this pull request as draft January 9, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to PatternFly 6
3 participants