Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert.Same() for map #1691

Open
tturbs opened this issue Jan 3, 2025 · 0 comments
Open

assert.Same() for map #1691

tturbs opened this issue Jan 3, 2025 · 0 comments

Comments

@tturbs
Copy link

tturbs commented Jan 3, 2025

Hello everyone,

I’d like to ask a quick question informally.
118fb83#diff-cfb0727d3ab618e656775b3bb99089481b38a25f8ece2b10913e2d88e492a165R531

I have some concerns regarding this commit. While the changes to the assert.Same() function seem appropriate for pointer comparisons, they are not suitable for comparing maps. In my case, it has become impossible to compare a map with its cloned copy.

If this change is considered appropriate, I believe there should be a separate function specifically for comparing pointer-like objects.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant