Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter should match <datalist> behavior #3

Open
tomayac opened this issue Dec 9, 2019 · 2 comments
Open

Filter should match <datalist> behavior #3

tomayac opened this issue Dec 9, 2019 · 2 comments
Labels
enhancement New feature or request usability-testing Add to usability testing list

Comments

@tomayac
Copy link

tomayac commented Dec 9, 2019

Rather than just filtering for startsWith, this component should probably match <datalist>'s "contains" filtering behavior (type "fox" in the input field in the example).

@stringyland
Copy link
Owner

Good idea - will do some usability testing to see what non-tech-savvy folks expect and update as needed.

@stringyland stringyland added enhancement New feature or request usability-testing Add to usability testing list labels Dec 11, 2019
@ollicle
Copy link
Contributor

ollicle commented Dec 11, 2019

I noticed this missing too, although it has potential to bring with it a lot of complexity:

  • When the match is not as obvious (as the first letters) the usual strategy to clarify the match by emphasising (e.g. bolding) the matched value in the text of the displayed options.
  • Another additional complication contains may bring is the need to reorder the options, e.g. it may make sense to rank full word matches higher than partial.

It would be valuable in assessing these usability and feature questions to detail some specific use cases where custom-select is particularly useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request usability-testing Add to usability testing list
Projects
None yet
Development

No branches or pull requests

3 participants