Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"when is NAME on call" failing with error #51

Closed
cboscolo opened this issue Jan 26, 2017 · 4 comments
Closed

"when is NAME on call" failing with error #51

cboscolo opened this issue Jan 26, 2017 · 4 comments

Comments

@cboscolo
Copy link

Deployed pagerbot using "Deploy to Heroku" button.

Issuing the following:
cboscolo [1:03 PM] pagerbot: when is andrew. on call
Results in:
pagerbot [1:03 PM] Hmm, that didn't seem to work: undefined method []' for nil:NilClass`

Everything else appears to work fine. For example, if I use the name of the schedule it works:
cboscolo [1:04 PM] pagerbot: when is andrew on normal
Results in:
pagerbot [1:04 PM] Andrew is not scheduled to go on Normal.

@macobo
Copy link
Contributor

macobo commented Jan 26, 2017

Thanks for the report - I'm sadly away from a dev environment for a week, will take a look as soon as I get the opportunity!

In the meantime, PRs are always welcome as well.

@macobo
Copy link
Contributor

macobo commented Feb 2, 2017

Sorry about the lack of a fix - I don't have access to a Pagerduty account anymore which means testing and verifying a fix is currently impossible. I've reached out to Pagerduty support, perhaps they'll let me have access to a testing account against which it'd even be possible to write integration tests.

In the meantime, happy to coach someone through solving this bug if there's interest!

@macobo macobo closed this as completed in 736a89c Feb 3, 2017
@macobo
Copy link
Contributor

macobo commented Feb 3, 2017

This is now fixed, thanks! 👍

Please let me know if you run into any other issues.

@cboscolo
Copy link
Author

cboscolo commented Feb 4, 2017

Thanks for fixing this nil reference issue! Unfortunately the semantics for use of the keyword call still do not work. I opened separate ticket for this. (#52) I am sorry I do not have more bandwidth to help you troubleshoot and fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants