Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Withdraw functionality is disabled when 100% of TVL limit is hit #163

Open
akiraonstarknet opened this issue Oct 3, 2024 · 4 comments · May be fixed by #174
Open

bug: Withdraw functionality is disabled when 100% of TVL limit is hit #163

akiraonstarknet opened this issue Oct 3, 2024 · 4 comments · May be fixed by #174
Assignees
@od-hunter
Labels
bug Something isn't working

Comments

@akiraonstarknet
Copy link
Contributor

Describe the bug
In the strategies page, when a strategy hits 100% of TVL limit, withdraws are not working. Ideally, just deposit shouldn't work, withdraws should still be functional.

To Reproduce
Steps to reproduce the behavior:

  1. Reduce the strategy TVL limit in strategies.atoms.ts to below current TVL value
  2. Try withdrawing, you will not be able to withdraw. Max and input button are disabled

Expected behavior
If user as deposits, withdraw should still function. User should be able to use max and enter input amount to withdraw

Screenshots or GIFs
image
@akiraonstarknet akiraonstarknet added the bug Something isn't working label Oct 3, 2024
@od-hunter
Copy link

Hi @akiraonstarknet , can I work on this please?

@Mystic-Nayy
Copy link
Contributor

Mystic-Nayy commented Oct 3, 2024 •
edited
Loading

@akiraonstarknet Can I please work on this?
To fix the bug, I will adjust the logic in strategies.atoms.ts so that the withdrawal button remains enabled even when the TVL limit is reached. Ensure the condition only affects deposits, not withdrawals. Then I will Test to confirm withdrawals work while deposits are disabled.

@akiraonstarknet
Copy link
Contributor Author

@od-hunter please give timeline to fix this. Need ASAP. ideally in 1-2 days.

@od-hunter
Copy link

@od-hunter please give timeline to fix this. Need ASAP. ideally in 1-2 days.

Hi @akiraonstarknet , working on it already ser.

This was referenced Oct 7, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@od-hunter od-hunter

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@od-hunter @Mystic-Nayy @akiraonstarknet