Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-Proxy Host cannot be set from UI #1703

Open
anki2189 opened this issue Mar 16, 2020 · 7 comments · May be fixed by strongbox/strongbox-web-ui#48
Open

Non-Proxy Host cannot be set from UI #1703

anki2189 opened this issue Mar 16, 2020 · 7 comments · May be fixed by strongbox/strongbox-web-ui#48
Labels
good first issue GraceHopperOSD Issues suitable for the Grace Hopper 2020 hackfest UI/UX This task will need or is related to user interface

Comments

@anki2189
Copy link
Member

anki2189 commented Mar 16, 2020 •
edited by carlspring
Loading

Bug Description

Non-Proxy host cannot be set from UI

Steps To Reproduce

  1. Login to Strongbox Instance (http://localhost:48080/).
  2. Go to Global repository Settings (http://localhost:48080/admin/server-settings) or any proxy repository (http://localhost:48080/admin/storages/storage-common-proxies/) or

Expected Behavior

We should be able to add non-proxy hosts list from UI.

Screenshots

Environment

  • Strongbox Version: {"strongbox":{"version":"1.0-SNAPSHOT","revision":"5b3132e2ec8ab20a"}}
  • OS: Should be on All OS
  • Maven version (please provide the full output of mvn --version):
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-05T00:30:29+05:30)
Maven home: /usr/local/Cellar/maven/3.6.1/libexec
Java version: 1.8.0_91, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
  • Browser (if related to UI): Google Chrome

Known Workarounds

Configure via command line using cUrl.

Task Relationships

This bug:

Help
@anki2189 anki2189 added the bug label Mar 16, 2020
@steve-todorov steve-todorov added UI/UX This task will need or is related to user interface and removed bug labels Mar 16, 2020
@steve-todorov
Copy link
Member

Thanks for reporting this issue. It's not exactly a bug but rather a feature needed to be implemented in the UI. I've added a label for it and if anybody would like to pick it up - feel free! :)

@carlspring carlspring added GraceHopperOSD Issues suitable for the Grace Hopper 2020 hackfest hacktoberfest Pre-selected issues for Hacktoberfest labels Jun 23, 2020
@carlspring
Copy link
Member

@anki2189 : What do you mean by "non-proxy" host? Would you mind adding some screenshots? Thanks!

@carlspring
Copy link
Member

@anki2189 : Ping? :)

@anki2189
Copy link
Member Author

anki2189 commented Jul 13, 2020 •
edited
Loading

@carlspring non-proxy is list/set of hosts which should not be used as proxy host. We should be able to set non-proxy host from UI too. ProxyConfigurationForm has

strongbox/strongbox-web-forms/src/main/java/org/carlspring/strongbox/forms/configuration/ProxyConfigurationForm.java

Line 41 in 61c8229

private List<String> nonProxyHosts = Lists.newArrayList();
, so backend supports non-proxy host but UI has this functionality missing.

Screen Shot 2020-07-13 at 11 19 35 AM

@carlspring
Copy link
Member

Thanks for the clarification!

@JohanDelValleV
Copy link

Is this issue still open? I'm looking for OP projects to contribute @carlspring

@carlspring
Copy link
Member

carlspring commented Dec 1, 2020 •
edited
Loading

Hi @JohanDelValleV ,

Yes, it's still open and nobody's working on it. Feel free to pick it up! :)

Also, please, feel free to join our chat channel.

@JohanDelValleV JohanDelValleV linked a pull request Dec 9, 2020 that will close this issue
Open
15 tasks
@steve-todorov steve-todorov removed the hacktoberfest Pre-selected issues for Hacktoberfest label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue GraceHopperOSD Issues suitable for the Grace Hopper 2020 hackfest UI/UX This task will need or is related to user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added dynamic textfields for nonProxyHosts JohanDelValleV/strongbox-web-ui
4 participants
@carlspring @steve-todorov @anki2189 @JohanDelValleV