-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve our checksum support for Maven metadata #1818
Improve our checksum support for Maven metadata #1818
Comments
@carlspring I can work on this task. |
Hi @sainalshah , Feel free to do so, if you think that the current task is clear enough. |
@carlspring Can I clarify whether the UI changes in strongbox-web-ui are part of this task, or I just need to ensure that the checksum request could be updated from UI? My understanding is, I could define the supported list of checksums in Maven2LayoutProvider class and per repository configuration could be retrieved from RepositoryData. Whenever the metadata is built/ rebuilt, the checksum would be updated as well. I still have to see how everything connects together though. Please let me know if I'm missing something. |
@sainalshah the frontend part is located in the strongbox-web-ui project and the backend part is at strongbox/strongbox. What @carlspring meant was that when you go in the UI at the I'm unsure if you should be able to select one or both checksum options @carlspring ? |
I think there should be checkboxes for these. By default, all four ( |
How're things going? |
I implemented some of the logic, but faced some difficulty when it came to implementing the test cases. Since it's my first time touching this part of the codebase, it's taking bit long for me. Plus I was bit busy these days. |
Sure, no problem! Let us know, if you have any problems, or questions. Good luck! :) |
Task Description
We should improve our support for checksums for
maven-metadata.xml
files. This seems to be a problem for Gradle artifacts and there is now support forsha256
andsha512
in Gradle. Maven Central (running on Nexus 2.x) now supports this.maven-metadata.xml
SHA256 and SHA512 checksums prevent publishing to NexusTasks
The following tasks will need to be carried out:
AbstractLayoutProvider.getDigestAlgorithmSet()
or theMaven2LayoutProvider
and apply the necessary fixes.org.carlspring.strongbox.services.impl.ArtifactMetadataServiceImpl
andorg.carlspring.strongbox.cron.jobs.RebuildMavenMetadataCronJob
.Task Relationships
This task:
Help
The text was updated successfully, but these errors were encountered: