Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file-name character encoding in command line tools on Windows #1358

Open
farindk opened this issue Oct 30, 2024 · 1 comment
Open

file-name character encoding in command line tools on Windows #1358

farindk opened this issue Oct 30, 2024 · 1 comment

Comments

@farindk
Copy link
Contributor

farindk commented Oct 30, 2024

Filenames with diacritics characters or other non-English glyphs are not processed correctly on Windows because of the different character encoding used.

@kmilos
Copy link
Contributor

kmilos commented Oct 31, 2024

If you're ok w/ making this work only on Windows 10 1903 and newer, the fix is to make libheif clients run in UTF-8 locale, so code is finally simplified and identical on all platforms.

See e.g. libjxl/libjxl@7b70ef1

Note that any existing -W API and wstring/wchar_t conversion can then be removed (incl. building w/ UNICODE macro and/or -municode switch for MinGW; it seems these were missing anyway).

Otherwise you'll also need the wmain() wrapper and handle wstring/wchar_t conversion of input arguments manually and/or use -W API appropriately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants