Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member signup #32

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Member signup #32

wants to merge 8 commits into from

Conversation

laurenzfg
Copy link
Collaborator

@laurenzfg laurenzfg commented Oct 21, 2020 •
edited by linusheck
Loading

This is the vogelnest part of the user sign up process. This is still work in progress. I will add these functionalities (but not tonight :-)). For some functionalities like add inactive pending or the group owner notification, I need to split up / add some API functions so that I can e.g. research the group owners from within the code.

  • Throw 500 if the user signs up for a non existent Lokalgruppe
  • Request for Allgemein (the present codebase treats the allgemein joining a little bit different to the legacy codebase)
  • Request for ones own LG
  • Notification of specific LG administrator

We need to at least perform these tests before deploying the PR:

  • Check if mailboxes are created (and forwarding???)
  • Check if the right people are correctly notified and can enable the user

@laurenzfg
Copy link
Collaborator Author

one can use this script to send test sign up requests to the api

@laurenzfg
Copy link
Collaborator Author

I completed the feauture. But please verify my changes & perfrom neccesarry tests @glatteis .

@laurenzfg laurenzfg changed the title [WIP] Member signup Member signup Oct 22, 2020
@laurenzfg laurenzfg linked an issue Oct 22, 2020 that may be closed by this pull request
User creation in CiviCRM #15
Open
@laurenzfg
Copy link
Collaborator Author

laurenzfg commented Oct 22, 2020 •
edited
Loading

@wanLo please verify that the right endpoint is hit for confirming email AND setting password. I modeled it after your pull request to sogintegration. (see commit eca3b59 )

@wanLo
Copy link
Member

wanLo commented Oct 22, 2020

Yup, looks good to me. After all, you corrected it yourself in c8d010b. The point being that we don't have unverified mail addresses for newly signed up users anyways, so confirming addresses makes no sense for now. We kind of confirm it by having only those with the right address receive the link to /confirm, but people with wrong addresses would still have their account be created (and activated) with the wrong address. Hence newly signed up users just have to set a password, which is done in frontend: /confirm.

@laurenzfg laurenzfg linked an issue Oct 23, 2020 that may be closed by this pull request
LDAP field mail alias #33
Open
@linusheck
Copy link
Contributor

Looks wonderful. I will work on the unchecked points later I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LDAP field mail alias User creation in CiviCRM
3 participants
@laurenzfg @wanLo @linusheck