Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserId should not be required for Groups #23

Open
sheharyarn opened this issue Nov 8, 2019 · 0 comments
Open

UserId should not be required for Groups #23

sheharyarn opened this issue Nov 8, 2019 · 0 comments

Comments

@sheharyarn
Copy link

user_id is one of the required arguments for the group/4. But Segment's own group docs only mention two fields; groupId and traits. This is because usually, you would use this to identify the group itself and not associate a user with a group.

This method should be updated to remove the user_id argument. If someone needs to pass it, they can use group/1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant