Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Referencing other components #109

Closed
LKay opened this issue Apr 23, 2020 · 2 comments
Closed

[FEATURE] Referencing other components #109

LKay opened this issue Apr 23, 2020 · 2 comments

Comments

@LKay
Copy link

LKay commented Apr 23, 2020

This library seems to be compatible with original styled-components but with Vue flavor, however interpolation other components as defined in docs: https://styled-components.com/docs/advanced#referring-to-other-components doesn't work and throws compilation errors.

@AasmundEndresen
Copy link

AasmundEndresen commented Jun 17, 2020

I've also been getting errors when extending components as a styled components - as can be done with original styled-components.

Like when doing something in the flavor of:

const Container = styled.div`
  width: 100%;
  border: 1px solid black;
`;

const StyledPageContainer = styled(Container)`
  border-color: red;
`;

const StyledSubContainer = styled(Container)`
  border-color: green;
`;

This doesn't work as expected, could it be a related issue?

It most notably causes issue if the original component is not a styled component like if I'm styling an Icon:

import { SomeIcon } from '~icons';

const StyledIcon = styled(SomeIcon)`
  fill: green;
`;

@liqueflies
Copy link
Collaborator

liqueflies commented Nov 28, 2020

Referencing other components is not a bug, it's a new feature that SC original library made after the first implementation of this library and I think Is related to #97.

@AasmundEndresen if you run the examples of this library this cases you are assuming not working it seems working.

@liqueflies liqueflies changed the title [BUG] Referencing other components is broken [FEATURE] Referencing other components is broken Nov 28, 2020
@liqueflies liqueflies changed the title [FEATURE] Referencing other components is broken [FEATURE] Referencing other components Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants