Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous #93

Open
williamspindox opened this issue May 18, 2023 · 5 comments
Open

Miscellaneous #93

williamspindox opened this issue May 18, 2023 · 5 comments
Labels

Comments

@williamspindox
Copy link

Feature request

Hi, some questions:

  1. is it possible to integrate your solution on AWS SageMaker? How?
  2. did you try your solution on Windows? After following your steps, I get: ModuleNotFoundError: No module named 'casalioy'. Please enhance README for Windows users too.
  3. I can run your docker image (please add -p 8501:8501 in the README for container run in order to access to the gui), but how can I update image after every new release without lost model and source_documents folders? Using a volume? Can you enhance README?

Thanks

Motivation

Improve your solution

Your contribution

@su77ungr su77ungr added bug Something isn't working setup labels May 18, 2023
@su77ungr
Copy link
Owner

su77ungr commented May 18, 2023

Gonna take on this issue tomorrow. Did you test the release v0.1.0 on windows? Edit: not the issue

1. is it possible to integrate your solution on AWS SageMaker? How?

No familiar with the AWS ecosystem. I know about SageMaker Labs that colab clone but that's it. If it's akin to a docker implemenation feel free to pitch me your approach of implementing it.

2. did you try your solution on Windows? After following your steps, I get: ModuleNotFoundError: No module named 'casalioy'. Please enhance README for Windows users too.

On remote and inactive rn. Gonna check this tomorrow.

3. I can run your docker image (please add -p 8501:8501 in the README for container run in order to access to the gui), but how can I update image after every new release without lost model and source_documents folders? Using a volume? Can you enhance README?

This will be added
Edit: done

@williamspindox
Copy link
Author

Yes, v0.1.0

@su77ungr
Copy link
Owner

Docker for Windows is not supported atm.

Is the (built from source) windows issue resolved? It might be a badly configured virtual env. Since I could recreate this error when running ingest.py after deactivating my venv. So I'll update the ReadMe for this case.

@williamspindox
Copy link
Author

Hi,
I can run your solution on Docker for Windows (the steps on your README are not complete, but it works), why do you say it's not supported?

I was able to run on Windows shell too (built from source) simply run "poetry shell" before call python commands.

About AWS SageMaker, yes it's like colab with jupyter notebook, I think you should deepen this integration, because different companies are migrating on cloud to get more cpu/gpu/storage performance.
Regards,

@su77ungr
Copy link
Owner

There were several issues with docker on Windows see #83. Also I did not test it for myself since I want Ubuntu to be running stable. Glad they have been resolved on your side.

Could you elaborate on the additional steps used by you to get this running on Windows, thanks.

@su77ungr su77ungr removed the bug Something isn't working label May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants