Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research pallet to replace generic-asset #1

Open
whalelephant opened this issue Oct 4, 2020 · 6 comments
Open

Research pallet to replace generic-asset #1

whalelephant opened this issue Oct 4, 2020 · 6 comments
Assignees

Comments

@whalelephant
Copy link
Contributor

Generic asset pallet has been remove from v2.0.0 release, reaons here

There have been two proposals to replace pallet-generic-assets with:

  1. pallet-assets
  2. tokens
  3. Look at Acala and see what they are doing

There is an active PR paritytech/substrate#7156 to add functionalities to the first option.

We should decide on this as it is a blocker to both parachains (generic and subdex) development

@whalelephant whalelephant changed the title Research pallet to to replace generic-asset Research pallet to replace generic-asset Oct 4, 2020
@whalelephant
Copy link
Contributor Author

whalelephant commented Oct 5, 2020

I suggest we use pallet-assets as it is actively being developed and maintained. The PR above will have additional functionalities that the open-runtime-module-lib/token do not (yet?) have. Since the aim of this milestone is to provide reusable pallets for the ecosystem, this might makes maintaining the pallets produced easier as we do not have to worry about if other projects have the same dependency versions.

@fyang1024
Copy link
Contributor

Yes, I think the asset pallet is more likely to to used for future cross-chain asset mapping

@iorveth
Copy link
Contributor

iorveth commented Oct 5, 2020

I am concerned that pallet-assets lack of mint/burn functionality. How xcmp transfers will be implemented than?
Suppose we can split the workflow into few steps:

  1. Create new xcmp message to pass total issuance along with actual amount to be transferred.
  2. Issue new wrapped token/perform wrapped currencies transfers from/to root account each time, xcmp message transfer occurs.

Though this does not look clear and we need to send message back to ensure funds were moved to our dex account on another para-chain.
If we go this way, i think it would even better to implement our own xcmp messages standard (invest, divest, exchange, etc.) to operate in fully remote way and distribute it as plugin.

What do you think guys? @whalelephant @fyang1024 @KStasi @herryho

@herryho
Copy link

herryho commented Oct 5, 2020

I read the pallet-assets very quikly, as well as the proposed PR #7156 in which Gavin listed some future implementations to pallet asset, and indeed I was unable to find the mint and burn functionalities that Arsen mentioned.

Meanwhile, the tokens pallet that Belsy put as option 2 was linked to open-runtime-module-libray, which is maitained by xlc(Bryan from Acala). Its last update was 3 days ago. Furthermore, I found Acala may be using tokens(Belsy's option 2) pallet or Currencies pallet, or both.(see this link).
Both pallets have burn and issue methods. So option 2 and option 3 are the same.

I don't quite understand the difference between tokens pallet and currencies pallet. Just try to provide some information. You guys please have a look at them. Shall we use them too?

@olanod
Copy link

olanod commented Oct 6, 2020

As a user this was a bit confusing, I started working with generic-asset and now I discovered it never made it to stable v2. Minting/Burning is a requirement for us so I'll go for whatever Acala is doing with ORML and luckly that also means that later on it will be easier to integrate with them. Is a goal of pallet-assets to eventually provide that kind of functionality? otherwise ORML tokens could be given a more official status and be recommended as the option to follow?

@whalelephant
Copy link
Contributor Author

hey @olanod thank you for joining the discussion! Great to have you here. I think we are going to put this on hold for couple of weeks and check back in then to see where these lib are at then to answers those questions you raised. Then we can continue the discussion!

@iorveth iorveth transferred this issue from another repository Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants