-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Research pallet to replace generic-asset #1
Comments
I suggest we use pallet-assets as it is actively being developed and maintained. The PR above will have additional functionalities that the open-runtime-module-lib/token do not (yet?) have. Since the aim of this milestone is to provide reusable pallets for the ecosystem, this might makes maintaining the pallets produced easier as we do not have to worry about if other projects have the same dependency versions. |
Yes, I think the asset pallet is more likely to to used for future cross-chain asset mapping |
I am concerned that pallet-assets lack of
Though this does not look clear and we need to send message back to ensure funds were moved to our dex account on another para-chain. What do you think guys? @whalelephant @fyang1024 @KStasi @herryho |
I read the pallet-assets very quikly, as well as the proposed PR #7156 in which Gavin listed some future implementations to pallet asset, and indeed I was unable to find the mint and burn functionalities that Arsen mentioned. Meanwhile, the tokens pallet that Belsy put as option 2 was linked to open-runtime-module-libray, which is maitained by xlc(Bryan from Acala). Its last update was 3 days ago. Furthermore, I found Acala may be using tokens(Belsy's option 2) pallet or Currencies pallet, or both.(see this link). I don't quite understand the difference between tokens pallet and currencies pallet. Just try to provide some information. You guys please have a look at them. Shall we use them too? |
As a user this was a bit confusing, I started working with generic-asset and now I discovered it never made it to stable v2. Minting/Burning is a requirement for us so I'll go for whatever Acala is doing with ORML and luckly that also means that later on it will be easier to integrate with them. Is a goal of pallet-assets to eventually provide that kind of functionality? otherwise ORML tokens could be given a more official status and be recommended as the option to follow? |
hey @olanod thank you for joining the discussion! Great to have you here. I think we are going to put this on hold for couple of weeks and check back in then to see where these lib are at then to answers those questions you raised. Then we can continue the discussion! |
Generic asset pallet has been remove from v2.0.0 release, reaons here
There have been two proposals to replace pallet-generic-assets with:
There is an active PR paritytech/substrate#7156 to add functionalities to the first option.
We should decide on this as it is a blocker to both parachains (generic and subdex) development
The text was updated successfully, but these errors were encountered: