Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New insight: body_qr_code_link.yml #1158

Merged
merged 4 commits into from
Dec 18, 2023
Merged

New insight: body_qr_code_link.yml #1158

merged 4 commits into from
Dec 18, 2023

Conversation

aidenmitchell
Copy link
Member

No description provided.

@aidenmitchell aidenmitchell requested a review from a team December 15, 2023 23:37
@morriscode
Copy link
Member

image

@morriscode
Copy link
Member

This appears to work as intended, however it could cause duplicate entries as there's no attachment length check.
In addition, I've ran into some inconsistencies with the QR code being identified in screenshots. I'll approve this for now, but I think we may need to refine.

@aidenmitchell aidenmitchell enabled auto-merge (squash) December 18, 2023 16:30
@aidenmitchell aidenmitchell merged commit d6c1bc8 into main Dec 18, 2023
3 checks passed
@aidenmitchell aidenmitchell deleted the aiden.insight.qrbody branch December 18, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morriscode morriscode morriscode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidenmitchell @morriscode