Adding extension-less Office file snippet #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rw-access
reviewed
Aug 21, 2023
| @@ -15,6 +15,12 @@ source: | | |||
| .file_extension in~ ("rtf", "doc", "docx") | |||
| or .file_extension in~ $file_extensions_common_archives | |||
| or .file_extension in~ $file_extensions_macros | |||
| or ( | |||
| .file_extension is null | |||
| and .file_type == "unknown" | |||
There was a problem hiding this comment.
Not blocking you, but it sounds like we should add more file type matchers based on the contents? That way we can detect pdf(x), ppt(x), doc(x), etc
There was a problem hiding this comment.
This rule specifically, or the snippet in general? Agreed that we should have more file type matching, but it shouldn't go inside the snippet.
There was a problem hiding this comment.
totally, nothing you need to change here yet. Just making an observation that it sounds like we're short on some file type matchers in the backend. If we did have extra matchers, then you'd want to update .file_type here
|
100000 is only .1mb. might want to bump it? |
|
/update-test-rules |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Adding extension-less Office file snippet by @aidenmitchell #679 Source SHA 7628945 Triggered by @morriscode
morriscode
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Office files without an extension appear as
in MQL, so adding this snippet to all of our Office file rules to ensure coverage. Size check is a guard rail.