Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP fix: Update link_microsoft_low_reputation.yml #791

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

morriscode
Copy link
Member

Adding more MS domain to linked domains, and requiring cred_theft of med/high confidence. Was firing on cred_theft low, on images with only a single word "Microsoft"

Adding more MS domain to linked domains, and requiring cred_theft of med/high confidence. Was firing on cred_theft low, on images with only a single word "Microsoft"
@morriscode morriscode requested a review from a team September 13, 2023 22:56
@morriscode
Copy link
Member Author

These regressions do not contains any microsoft specific content, the rule explicitly looks for a MS logo, and the failed regressions are not Microsoft themed at all. These are acceptable regressions.

@morriscode morriscode requested a review from jkamdjou September 18, 2023 23:24
@morriscode morriscode merged commit a979ae9 into main Sep 20, 2023
4 checks passed
@morriscode morriscode deleted the sam.ms.lowrep branch September 20, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants