Update link_google_translate.yml #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to use the google_translate_open_redirect encoder.
rw-access
reviewed
Oct 18, 2023
Co-authored-by: Ross Wolf <[email protected]>
|
@rw-access After thinking about it..I don't know if we want to support the backwards compatibility with this one specifically. The previous logic was prone to false positives even if the query params were clearly not a URL, the encoder seems to take into consideration if the translate.goog contains a url. |
rw-access
reviewed
Oct 18, 2023
Co-authored-by: Ross Wolf <[email protected]>
rw-access
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to use the google_translate_open_redirect encoder.