Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update body_advance_fee_new_sender.yml #922

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Update body_advance_fee_new_sender.yml #922

merged 3 commits into from
Jan 30, 2024

Conversation

morriscode
Copy link
Member

No description provided.

@morriscode
Copy link
Member Author

/update-test-rules

github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
Sync from PR#922
07b9f30 
Update body_advance_fee_new_sender.yml by @morriscode
#922
Source SHA cfbd6ec
Triggered by @morriscode
@morriscode morriscode requested review from a team and aidenmitchell January 30, 2024 16:17
@morriscode morriscode marked this pull request as ready for review January 30, 2024 16:17
@aidenmitchell
Copy link
Member

@morriscode some Mimic failures here, should they be fixed?

@morriscode
Copy link
Member Author

morriscode commented Jan 30, 2024 •
edited
Loading

/mql-mimic-exempt: 34360, 34071, 34042, 34073, 33936, 33746, 33722, 33733, 33724, 33536
Checked several of these and they were QR codes or MS impersonation. The ones reporting 0 rules matching actually fire 3 rules

@morriscode
Copy link
Member Author

morriscode commented Jan 30, 2024 •
edited
Loading

mimic failures were do to being out of sync with main

@morriscode morriscode enabled auto-merge (squash) January 30, 2024 21:48
@morriscode morriscode merged commit 8dea4f6 into main Jan 30, 2024
3 checks passed
@morriscode morriscode deleted the morriscode-aff.patch branch January 30, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidenmitchell aidenmitchell aidenmitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morriscode @aidenmitchell