[PHP] block comments are not working as expected if they are placed inside a <script> tag

[arasanoutdoinc]

What happened?

After applying the patch from this GitHub repository: https://github.com/jfcherng-sublime/ST-my-settings/blob/master/scripts/update_official_packages.sh, the overall functionality seems to be working fine.

However, there is an issue with the PHP block comment inside the script tag, which is not functioning correctly.

followed by #3811

[michaelblyons]

It's always helpful to include your sample code as text as well as the screenshot, so testers can copy it without retyping.

[deathaxe]

PHP tags are embedded in CSS/JavaScript to keep syntax size and complexity in sane limits.

Packages/PHP/JavaScript (PHP).sublime-syntax

Lines 37 to 45 in 74c43d2

	- match: <\?(?i:php\b|=)?
	scope: meta.embedded.php punctuation.section.embedded.begin.php
	embed: Packages/PHP/PHP Source.sublime-syntax
	embed_scope: meta.embedded.php source.php.embedded.js
	escape: (\?>)(\s*\n)?
	escape_captures:
	0: meta.embedded.php
	1: punctuation.section.embedded.end.php
	2: meta.html-newline-after-php.php

PHP Source.sublime-syntax is mainly designed to switch between html<->php.

Not sure what a solution would look like without risk of hitting 25k context sanity limit and keep already significant complexity in sane limits.

It's hard to mix 2 context sensitive syntaxes such as PHP and JavaScript without bloating resource usage and complexity.

Not sure whether its worth for such a tiny edge case. There are likely more when using PHP within JS/CSS. Those are designed to take simple php expressions only.