[C] Add digit separator like is already implemented for C++ #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C23 added this feature previously available in C++. This should close sublimehq#3972 as well as both C and C++ now have syntax support for the ' digit separator. This was implemented by just copying the digit variables from the C++ syntax file as it is the same construct in the end. The existing tests were updated to fix the part of the existing tests were broken by this new feature. Furthermore, some tests from C++ were adapted for C to add better testing for the new digit seperator. I also included tests for the newer base 2 integer contants. The C file did not have any tests for that yet.
braewoods
force-pushed
the
c-digit-separator
branch
from
c7c977a
to
2b6f6ee
Compare
|
I fixed the test issues with Objectice-C. |
deathaxe
reviewed
Nov 24, 2024
Comment on lines
+1177
to
1179
| /* ^^^^^ constant.numeric.value.c */ | ||
| /* ^^^^ invalid.illegal.numeric.suffix.c */ | ||
| /* ^^^^^^ meta.number.integer.decimal.c */ |
There was a problem hiding this comment.
I'd suggest to extend existing meta.number test to cover whole constant.
Suggested change
| /* ^^^^^ constant.numeric.value.c */ | |
| /* ^^^^ invalid.illegal.numeric.suffix.c */ | |
| /* ^^^^^^ meta.number.integer.decimal.c */ | |
| /* ^^^^^^^^^^^^^^^^ meta.number.integer.decimal.c */ | |
| /* ^^^^^ constant.numeric.value.c */ | |
| /* ^^^^ invalid.illegal.numeric.suffix.c */ |
Comment on lines
+923
to
925
| /* ^^^^^ constant.numeric.value.c */ | ||
| /* ^^^^ invalid.illegal.numeric.suffix.c */ | ||
| /* ^^^^^^ meta.number.integer.decimal.c */ |
There was a problem hiding this comment.
Same here
Suggested change
| /* ^^^^^ constant.numeric.value.c */ | |
| /* ^^^^ invalid.illegal.numeric.suffix.c */ | |
| /* ^^^^^^ meta.number.integer.decimal.c */ | |
| /* ^^^^^^^^^^^^^^^^ meta.number.integer.decimal.c */ | |
| /* ^^^^^ constant.numeric.value.c */ | |
| /* ^^^^ invalid.illegal.numeric.suffix.c */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C23 added this feature previously available in C++. This should close #3972 as well as both C and C++ now have syntax support for the ' digit separator.
This was implemented by just copying the digit variables from the C++ syntax file as it is the same construct in the end. The existing tests were updated to fix the part of the existing tests were broken by this new feature.
Furthermore, some tests from C++ were adapted for C to add better testing for the new digit seperator. I also included tests for the newer base 2 integer contants. The C file did not have any tests for that yet.