Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goto Symbol in Project is slow for large projects #2672

Closed
ismell opened this issue Mar 5, 2019 · 13 comments
Closed

Goto Symbol in Project is slow for large projects #2672

ismell opened this issue Mar 5, 2019 · 13 comments

Comments

@ismell
Copy link

ismell commented Mar 5, 2019

Goto Symbol in Project takes a considerable amount of time to load when working on the linux kernel.

git clone https://github.com/torvalds/linux.git
subl linux
Wait for indexing to complete
Ctrl+Shift+R (Takes ~4 seconds on my box)

Ctrl+Shift+F sometimes takes less time then searching all the symbols. I'm assuming it's because it renders the whole list up front.

@FichteFoll
Copy link
Collaborator

Has indexing already completed when you request the popup?

@ismell
Copy link
Author

ismell commented Mar 5, 2019

Yeah it has. Guess I should have added that into the repo instructions.

@wbond
Copy link
Member

wbond commented Mar 7, 2019

This should be sorted in build 3195. I'd recommend waiting for 3196 to confirm since there is a freezing issue affecting some setups in 3195.

@ismell
Copy link
Author

ismell commented Mar 7, 2019

Ohh awesome!

I was seeing some reports internally that Ctrl + P was also slow when working on the android code. Will the fix address this as well, or should I file another bug for that?

@wbond
Copy link
Member

wbond commented Mar 8, 2019

I would check and see if you still have the issue in 3197, and if so, open the issue. We've put a few performance optimizations in place related to general filter lists and for symbol matching specifically. Hopefully the general filter list improvements should solve the Goto Anything issues your colleagues were seeing.

@ismell
Copy link
Author

ismell commented Mar 8, 2019

So Ctrl + Shift + R is a bit faster now. It still takes roughly 3 seconds on my Xeon Gold 6154.

@ismell
Copy link
Author

ismell commented Mar 16, 2019

@FichteFoll can you remove the R:Fixed tag? Thanks

@FichteFoll FichteFoll reopened this Mar 18, 2019
@FichteFoll FichteFoll removed this from the Build 3195 milestone Mar 18, 2019
@FichteFoll
Copy link
Collaborator

How many symbols are we talking about here? It's kinda problematic to find out because ST doesn't expose this info.

@wbond
Copy link
Member

wbond commented Mar 18, 2019

The Indexer Status window says how many symbols:

index "sublime_text..." is using 14481920 bytes for 161982 symbols across 1602203 locations

@ismell
Copy link
Author

ismell commented Mar 18, 2019

Using the C syntax from sublimehq/Packages#1831

index "v4.14..." collated in 3.08s from 62835 files
index "v4.14..." is using 89,788,736 bytes for 1,879,865 symbols across 6,501,658 locations

@wbond
Copy link
Member

wbond commented Mar 18, 2019

Yeah, I'm seeing collation of 0.5s from 26k files. The collation speed sounds like the delay you are seeing invoking the Goto Symbol in Project.

@djspiewak
Copy link

For the record, I'm having similar issues and always have, though I'm now running Sublime across a larger set of source files than I have in the past, and the issues definitely get a lot worse in such cases:

index "slamdata" is using 2314240 bytes for 15975 symbols across 44369 locations

Cmd-Shift-R doesn't take three seconds to render, but it's definitely pretty close to one second. Cmd-T is also quite slow, though more like 500ms. Cmd-R is always instant.

@FichteFoll FichteFoll added this to the next dev cycle milestone Nov 25, 2019
@BenjaminSchaaf
Copy link
Member

Fixed in Sublime Text 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants