Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to explicitly disable probes of Sophora Server #104

Closed
hehu80 opened this issue Jul 4, 2024 · 2 comments
Closed

Allow to explicitly disable probes of Sophora Server #104

hehu80 opened this issue Jul 4, 2024 · 2 comments

Comments

@hehu80
Copy link
Contributor

hehu80 commented Jul 4, 2024

If you want to disable a probe of the Sophora Server, you have to "delete" the default values by setting for example .Values.livenessProbe to null in the values.yaml.
Unfortunately, deleting of default-values using null is not possible while using Helm with sub-charts (see open PR).
Adding another enabled flag to enable or disable probes would be great.

For example:

livenessProbe:
   enabled: true
   periodSeconds: 20
   ...

to configure the livenessProbe

livenessProbe:
   enabled: false

to disable the livenessProbe
hehu80 added a commit to hehu80/subshell-helm-charts that referenced this issue Jul 4, 2024
@hehu80
[sophora-server]: add flags to enable probes (subshell#104)
0c01d83
@hehu80
Copy link
Contributor Author

hehu80 commented Jul 4, 2024

#105

hehu80 added a commit to hehu80/subshell-helm-charts that referenced this issue Jul 8, 2024
@hehu80
[sophora-server]: bump version (subshell#104)
6fea78f
philmtd added a commit to hehu80/subshell-helm-charts that referenced this issue Jul 9, 2024
@philmtd
Merge branch 'main' into subshell#104-allow-to-explicitly-disable-pro…
036f037 
…bes-of-sophora-server
philmtd added a commit that referenced this issue Jul 9, 2024
@hehu80 @philmtd
[sophora-server]: add flags to enable or disable probes (#104) (#105)
fda2d53 
* [sophora-server]: add flags to enable probes (#104)

* [sophora-server]: bump version (#104)

---------

Co-authored-by: Philip Dakowitz <[email protected]>
@philmtd
Copy link
Member

philmtd commented Jul 9, 2024

Closed by #105

@philmtd philmtd closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hehu80 @philmtd