New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential typo in comment exporter #6

Open

e-e-e opened this issue Apr 29, 2018 · 0 comments

e-e-e commented Apr 29, 2018

This simple writer does not have an exporter - but I think that this line potentially has a typo with the placement of brackets. https://github.com/substance/simple-writer/blob/master/lib/comment/CommentConverter.js#L28 Exporter is never called by simple-writer so this is not obvious.

Should it read?

  export: function(node, el) {
    el.attr({
      'data-type': 'comment',
      'data-comment': node.content
    }).append(node.content)
  }

Also also - why are you appending node.content to the element as well as adding node.content as an attribute. Is this correct too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment