Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Resource Profiles without requiring pod restart #151

Open
samos123 opened this issue Aug 30, 2024 · 0 comments
Open

Modify Resource Profiles without requiring pod restart #151

samos123 opened this issue Aug 30, 2024 · 0 comments

Comments

@samos123
Copy link
Contributor

samos123 commented Aug 30, 2024

Relevant quote:

"the kubeai controller pod is supposed to pick up changes to configs without restarting right (e.g. adding a new resource profile via the helm values file)? I've created a resource profile and new model crd but it doesn't seem to pick it up and spin up a new replica. Nothing of note in the logs, and I don't want to restart the controller pod since there's active usage"

Today the resource profiles are defined in a configmap. KubeAI however does not automatically pick up any changes in this configmap.

We should consider that modifying ResourceProfile is a common operation. So depending on pod restarts isn't ideal. A pod restart could cause issues to existing connections.

@samos123 samos123 changed the title Modifying helm values resourceProfile should auto refresh kubeai controller Modifying kubeai configmap should auto refresh kubeai controller Aug 30, 2024
@samos123 samos123 changed the title Modifying kubeai configmap should auto refresh kubeai controller Modify Resource Profiles without requiring pod restart Sep 17, 2024
nstogner added a commit that referenced this issue Sep 17, 2024
…ield (#214)

Restart KubeAI to pick up changes to configmap.
See:
https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments

Hot-reload was considered - however it gets complicated b/c of
long-running processes that get started such as messengers and
autoscaling. We can punt on that until later.

Related to #151 which can be implemented seperately.

Also added `.messaging` to ConfigMap (it was omitted).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant