Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests need constant state #67

Closed
ns-rse opened this issue Nov 22, 2024 · 0 comments · Fixed by #71
Closed

Tests need constant state #67

ns-rse opened this issue Nov 22, 2024 · 0 comments · Fixed by #71
Assignees
Labels
tests Testing issues

Comments

@ns-rse
Copy link
Contributor

ns-rse commented Nov 22, 2024

I've noticed whilst working on #65 that the regression test introduced in #62 failed.

As far as I could tell what had changed was the order of entries in the output, which is strange as the current code is looping over things so unless the order of the iterables changes each time code is run I wouldn't expect this to change.

For now though a temporary fix to ensure that the tests always pass is to sort the dataframe that has been introduced to undertake the regression test. This should be done based on the transcript_id, start and end columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Testing issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant