Skip to content

Commit

Permalink
Restrict-qualify sudo_hexchar_v1
Browse files Browse the repository at this point in the history
sudo_hexchar_v1 requires an array of at least size-2, and is not aliased.
  • Loading branch information
AreaZR committed Aug 13, 2024
1 parent e3fd614 commit 1013588
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion include/sudo_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ sudo_dso_public int sudo_getgrouplist2_v1(const char *name, gid_t basegid, GETGR
#define sudo_getgrouplist2(_a, _b, _c, _d) sudo_getgrouplist2_v1((_a), (_b), (_c), (_d))

/* hexchar.c */
sudo_dso_public int sudo_hexchar_v1(const char *s);
sudo_dso_public int sudo_hexchar_v1(const char s[restrict static 2]);
#define sudo_hexchar(_a) sudo_hexchar_v1(_a)

/* key_val.c */
Expand Down
2 changes: 1 addition & 1 deletion lib/util/hexchar.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
* Returns a value 0-255 on success or -1 for invalid input.
*/
int
sudo_hexchar_v1(const char *s)
sudo_hexchar_v1(const char s[restrict static 2])
{
unsigned char result[2];
unsigned int i;
Expand Down

0 comments on commit 1013588

Please sign in to comment.