Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

governance/proposals route is not consistence in its returns. #1

Open
FidelVe opened this issue Jun 29, 2022 · 3 comments
Open

governance/proposals route is not consistence in its returns. #1

FidelVe opened this issue Jun 29, 2022 · 3 comments
Assignees
@coder1963

Comments

@FidelVe
Copy link

FidelVe commented Jun 29, 2022

Im using the API for a bot to check when new proposals are submitted into the network and notify me of this so that I dont get a penalty for not voting in a network proposal.

Im trying to use the api/v1/governance/proposals route to get the proposals and parse that data but the response is not consistence. Yesterday it gave me back an array of all 40 network proposals in the chain, starting from oldest to newest, today is only replying with the following:

[
  {
    "proposer": "hxff6437443e7ed76d2d7f97f0d28d7ae1071bd0bb",
    "id": 10,
    "proposer_name": "Spartan Node",
    "start_block_height": 41413785,
    "title": "Malicious SCORE Proposal",
    "type": "0x2",
    "agree_amount": "77987728.48351024",
    "disagree_amount": "7482353.780856997",
    "no_vote_amount": "233539816.42498818",
    "status": "0x2",
    "contents_json": {
      "description": "It has been discussed amongst us P-Reps of a contract that is generating a lot of failed transactions and some serious spam on the Icon network.  As noted by Geometry Labs and a foundation member that this is not a good SCORE and seems to be malicious. We propose the SCORE be frozen in order to protect the network from needless failed transactions and possible network interference.",
      "title": "Malicious SCORE Proposal",
      "type": "0x2"
    },
    "end_block_height": 41451602,
    "description": "It has been discussed amongst us P-Reps of a contract that is generating a lot of failed transactions and some serious spam on the Icon network.  As noted by Geometry Labs and a foundation member that this is not a good SCORE and seems to be malicious. We propose the SCORE be frozen in order to protect the network from needless failed transactions and possible network interference.",
    "agree_count": "0.000000000000000006",
    "disagree_count": "0.000000000000000001",
    "no_vote_count": "0.000000000000000015"
  },
  {
    "proposer": "hx0b047c751658f7ce1b2595da34d57a0e7dad357d",
    "id": 9,
    "proposer_name": "ICON Foundation",
    "start_block_height": 41730213,
    "title": "Revision 13 Proposal",
    "type": "0x1",
    "agree_amount": "245820938.0168674",
    "disagree_amount": "0.0",
    "no_vote_amount": "70911096.70617676",
    "status": "0x1",
    "contents_json": {
      "description": "<h1>Revision 13 Proposal</h1><p>The ICON Foundation submits a Network Proposal (Revision Proposal) to activate the Revision 13 feature. The functions for Revision 13 are already included in Loopchain 2.8.1, ICON Service 1.9.1, icon-rpc-server 1.7.2. and Reward calculator 1.2.6. You can find a release note for this update here - https://icondev.io/release-notes/2021-10-22</p><h2>Summary of this update</h2><h3>ICON1</h3><ul><li>Stop block generation when revision 13 is approved</li><li>Provide a command to convert old private key(pem or der) to json keystore</li><li>Fix debug_estimateStep API failure</li></ul><h3>ICON2</h3><ul><li>Enabled bond related APIs</li><li>New global variables are announced</li><li>Fix a bug in setDelegation</li></ul>",
      "title": "Revision 13 Proposal",
      "type": "0x1"
    },
    "end_block_height": 41753442,
    "description": "<h1>Revision 13 Proposal</h1><p>The ICON Foundation submits a Network Proposal (Revision Proposal) to activate the Revision 13 feature. The functions for Revision 13 are already included in Loopchain 2.8.1, ICON Service 1.9.1, icon-rpc-server 1.7.2. and Reward calculator 1.2.6. You can find a release note for this update here - https://icondev.io/release-notes/2021-10-22</p><h2>Summary of this update</h2><h3>ICON1</h3><ul><li>Stop block generation when revision 13 is approved</li><li>Provide a command to convert old private key(pem or der) to json keystore</li><li>Fix debug_estimateStep API failure</li></ul><h3>ICON2</h3><ul><li>Enabled bond related APIs</li><li>New global variables are announced</li><li>Fix a bug in setDelegation</li></ul>",
    "agree_count": "0.000000000000000015",
    "disagree_count": "0.0",
    "no_vote_count": "0.000000000000000007"
  },
  {
    "proposer": "hx0b047c751658f7ce1b2595da34d57a0e7dad357d",
    "id": 8,
    "proposer_name": "ICON Foundation",
    "start_block_height": 43481610,
    "title": "Monthly Reward Fund Setting Proposal",
    "type": "0x7",
    "agree_amount": "266146415.74059677",
    "disagree_amount": "0.0",
    "no_vote_amount": "36170948.58377909",
    "status": "0x1",
    "contents_json": {
      "description": "<h1>Reward Fund Setting Proposal</h1><p>The ICON Foundation submits a Network Proposal to set monthly reward fund to 3000000 ICX</p>",
      "title": "Monthly Reward Fund Setting Proposal",
      "type": "0x7"
    },
    "end_block_height": 43521362,
    "description": "<h1>Reward Fund Setting Proposal</h1><p>The ICON Foundation submits a Network Proposal to set monthly reward fund to 3000000 ICX</p>",
    "agree_count": "0.000000000000000018",
    "disagree_count": "0.0",
    "no_vote_count": "0.000000000000000004"
  },
  {
    "proposer": "hx0b047c751658f7ce1b2595da34d57a0e7dad357d",
    "id": 7,
    "proposer_name": "ICON Foundation",
    "start_block_height": 43481620,
    "title": "Reward Fund Allocation Proposal",
    "type": "0x8",
    "agree_amount": "258861163.50955334",
    "disagree_amount": "0.0",
    "no_vote_amount": "43456200.81482252",
    "status": "0x1",
    "contents_json": {
      "description": "<h1>Reward Fund Allocation Proposal</h1><p>The ICON Foundation submits a Network Proposal to set reward fund allocation proportion</p><ul><li>prep: 13</li><li>cps: 10</li><li>relay: 0</li><li>voter: 77</li></ul>",
      "title": "Reward Fund Allocation Proposal",
      "type": "0x8"
    },
    "end_block_height": 43521362,
    "description": "<h1>Reward Fund Allocation Proposal</h1><p>The ICON Foundation submits a Network Proposal to set reward fund allocation proportion</p><ul><li>prep: 13</li><li>cps: 10</li><li>relay: 0</li><li>voter: 77</li></ul>",
    "agree_count": "0.000000000000000017",
    "disagree_count": "0.0",
    "no_vote_count": "0.000000000000000005"
  },
  {
    "proposer": "hx0b047c751658f7ce1b2595da34d57a0e7dad357d",
    "id": 6,
    "proposer_name": "ICON Foundation",
    "start_block_height": 43781435,
    "title": "Step costs Proposal",
    "type": "0x6",
    "agree_amount": "294517191.6416631",
    "disagree_amount": "0.0",
    "no_vote_amount": "6542345.50867834",
    "status": "0x1",
    "contents_json": {
      "description": "<h1>Step costs Proposal</h1><p>The ICON Foundation submits a Network Proposal to set step costs for new fee policy</p><p>Refer to this <a href=https://forum.icon.community/t/icon-2-0-score-fee-policy-update-draft-proposal/2194>link</a> for more details</p><ul><li>schema: 1</li><li>default: 100,000</li><li>input: 200</li><li>contractCall: 25,000</li><li>contractCreate: 1,000,000,000</li><li>contractUpdate: 1,000,000,000</li><li>contractSet: 15,000</li><li>get: 25</li><li>set: 320</li><li>delete: -240</li><li>apiCall: 10,000</li><li>getBase: 3,000</li><li>setBase: 10,000</li><li>deleteBase: 200</li><li>logBase: 5,000</li><li>log: 100</li><li>contractDestruct: 0</li><li>replace: 0</li><li>eventLog: 0</li></ul>",
      "title": "Step costs Proposal",
      "type": "0x6"
    },
    "end_block_height": 43823202,
    "description": "<h1>Step costs Proposal</h1><p>The ICON Foundation submits a Network Proposal to set step costs for new fee policy</p><p>Refer to this <a href=https://forum.icon.community/t/icon-2-0-score-fee-policy-update-draft-proposal/2194>link</a> for more details</p><ul><li>schema: 1</li><li>default: 100,000</li><li>input: 200</li><li>contractCall: 25,000</li><li>contractCreate: 1,000,000,000</li><li>contractUpdate: 1,000,000,000</li><li>contractSet: 15,000</li><li>get: 25</li><li>set: 320</li><li>delete: -240</li><li>apiCall: 10,000</li><li>getBase: 3,000</li><li>setBase: 10,000</li><li>deleteBase: 200</li><li>logBase: 5,000</li><li>log: 100</li><li>contractDestruct: 0</li><li>replace: 0</li><li>eventLog: 0</li></ul>",
    "agree_count": "0.000000000000000021",
    "disagree_count": "0.0",
    "no_vote_count": "0.000000000000000001"
  },
  {
    "proposer": "hx0b047c751658f7ce1b2595da34d57a0e7dad357d",
    "id": 5,
    "proposer_name": "ICON Foundation",
    "start_block_height": 43825052,
    "title": "Revision 14 Proposal",
    "type": "0x1",
    "agree_amount": "241869780.40311912",
    "disagree_amount": "0.0",
    "no_vote_amount": "59585359.65811393",
    "status": "0x1",
    "contents_json": {
      "description": "<h1>Revision 14 Proposal</h1><p>The ICON Foundation submits a Network Proposal (Revision Proposal) to activate the Revision 14 feature.</p><h2>Summary</h2><ul><li>IISS 3.1 full features are activated</li><li>Virtual step is disabled</li></ul>",
      "title": "Revision 14 Proposal",
      "type": "0x1"
    },
    "end_block_height": 43866322,
    "description": "<h1>Revision 14 Proposal</h1><p>The ICON Foundation submits a Network Proposal (Revision Proposal) to activate the Revision 14 feature.</p><h2>Summary</h2><ul><li>IISS 3.1 full features are activated</li><li>Virtual step is disabled</li></ul>",
    "agree_count": "0.00000000000000002",
    "disagree_count": "0.0",
    "no_vote_count": "0.000000000000000002"
  },
  {
    "proposer": "hxfba37e91ccc13ec1dab115811f73e429cde44d48",
    "id": 4,
    "proposer_name": "ICX_Station",
    "start_block_height": 43867203,
    "title": "Revision 15 Proposal",
    "type": "0x1",
    "agree_amount": "103862957.45814389",
    "disagree_amount": "0.0",
    "no_vote_amount": "13828312.598",
    "status": "0x1",
    "contents_json": {
      "description": "<h1>Revision 15 Proposal</h1><p>The ICON Foundation submits a Network Proposal (Revision Proposal) to activate the Revision 15 feature.<h2>Summary</h2><ul><li>Java Score is available under the new fee policy</li></ul>",
      "title": "Revision 15 Proposal",
      "type": "0x1"
    },
    "end_block_height": 43909442,
    "description": "<h1>Revision 15 Proposal</h1><p>The ICON Foundation submits a Network Proposal (Revision Proposal) to activate the Revision 15 feature.<h2>Summary</h2><ul><li>Java Score is available under the new fee policy</li></ul>",
    "agree_count": "0.000000000000000018",
    "disagree_count": "0.0",
    "no_vote_count": "0.000000000000000004"
  },
  {
    "proposer": "hx0b047c751658f7ce1b2595da34d57a0e7dad357d",
    "id": 3,
    "proposer_name": "ICON Foundation",
    "start_block_height": 43909580,
    "title": "Revision 16 Proposal",
    "type": "0x1",
    "agree_amount": "142886907.38554546",
    "disagree_amount": "0.0",
    "no_vote_amount": "19634702.403884683",
    "status": "0x1",
    "contents_json": {
      "description": "<h1>Revision 16 Proposal</h1><p>The ICON Foundation submits a Network Proposal (Revision Proposal) to activate the Revision 16 feature. You can find a release note for this update here - <a href=https://icondev.io/release-notes/2021-12-23>Release Note</a></p><h2>Summary</h2><ul><li>Fix ICX issue and regulate module</li></ul>",
      "title": "Revision 16 Proposal",
      "type": "0x1"
    },
    "end_block_height": 43952562,
    "description": "<h1>Revision 16 Proposal</h1><p>The ICON Foundation submits a Network Proposal (Revision Proposal) to activate the Revision 16 feature. You can find a release note for this update here - <a href=https://icondev.io/release-notes/2021-12-23>Release Note</a></p><h2>Summary</h2><ul><li>Fix ICX issue and regulate module</li></ul>",
    "agree_count": "0.000000000000000016",
    "disagree_count": "0.0",
    "no_vote_count": "0.000000000000000006"
  },
  {
    "proposer": "hx0b047c751658f7ce1b2595da34d57a0e7dad357d",
    "id": 2,
    "proposer_name": "ICON Foundation",
    "start_block_height": 46841895,
    "title": "Revision 17 Proposal",
    "type": "0x1",
    "agree_amount": "216410573.04143304",
    "disagree_amount": "0.0",
    "no_vote_amount": "37711839.704216264",
    "status": "0x1",
    "contents_json": {
      "description": "<h1>Revision 17 Proposal</h1><h2>Summary</h2><ul><li>Enable getScoreOwner and setScoreOwner APIs</li><li>Activate 3 Extra Main PReps</li></ul>",
      "title": "Revision 17 Proposal",
      "type": "0x1"
    },
    "end_block_height": 46884722,
    "description": "<h1>Revision 17 Proposal</h1><h2>Summary</h2><ul><li>Enable getScoreOwner and setScoreOwner APIs</li><li>Activate 3 Extra Main PReps</li></ul>",
    "agree_count": "0.000000000000000018",
    "disagree_count": "0.0",
    "no_vote_count": "0.000000000000000004"
  },
  {
    "proposer": "hx0b047c751658f7ce1b2595da34d57a0e7dad357d",
    "id": 1,
    "proposer_name": "ICON Foundation",
    "start_block_height": 48963430,
    "title": "CPS network SCORE Designation Proposal",
    "type": "0x9",
    "agree_amount": "247704657.43205038",
    "disagree_amount": "6734154.6510091415",
    "no_vote_amount": "1924193.8787207429",
    "status": "0x1",
    "contents_json": {
      "description": "This proposal is intended to designate a network SCORE to receive CPS fund from ICON network",
      "title": "CPS network SCORE Designation Proposal",
      "type": "0x9"
    },
    "end_block_height": 49170082,
    "description": "This proposal is intended to designate a network SCORE to receive CPS fund from ICON network",
    "agree_count": "0.000000000000000023",
    "disagree_count": "0.000000000000000002",
    "no_vote_count": "0.0"
  }
]

incidentally this response also doesnt have the latest revision 19 proposal.
@robcxyz
Copy link
Contributor

robcxyz commented Jan 13, 2023

@FidelVe - Sorry for late reply on this. We don't use this endpoint in the tracker / anywhere but if there is an error, it should be addressed.

Can you check now if it is alright?

https://tracker.v2.mainnet.sng.vultr.icon.community/api/v1/governance/docs#/default/get_proposals_api_v1_governance_proposals_get

I count 12 proposals. If there should be more / some are missing. Let me know. Otherwise I'll close this.

@FidelVe
Copy link
Author

FidelVe commented Jan 13, 2023

Hi @robcxyz

I ended up fetching the proposal data directly from the chain using the contract cx0000000000000000000000000000000000000001

https://github.com/Espanicon/icon-node-monitor/blob/master/api/networkProposals.js#L53

@robcxyz
Copy link
Contributor

robcxyz commented Dec 9, 2024

Coming back to this - I think this is simply because that endpoint is not updated but @coder1963 - can you check this out and we'll close it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coder1963 coder1963

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robcxyz @FidelVe @coder1963