Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines exceeding 72 characters #19

Open
mcd500 opened this issue Dec 30, 2024 · 0 comments
Open

Lines exceeding 72 characters #19

mcd500 opened this issue Dec 30, 2024 · 0 comments

Comments

@mcd500
Copy link

mcd500 commented Dec 30, 2024

There are lines exceeding the 72 characters width limit which require to be fixed for the I.D.
Some of them in the cddl file could be eliminated by removing the indentation with three spaces.

These are the messages from the idnits tool.

Warnings on XML file:

suit-wg/suit-report/draft-ietf-suit-report.xml(413): Warning: Too long line found (L530), 1 characters longer than 72 characters:
     suit-component-capabilities        => [+ SUIT_Component_Capability ]
suit-wg/suit-report/draft-ietf-suit-report.xml(457): Warning: Too long line found (L621), 2 characters longer than 72 characters:
   SUIT_Report_Protected /= SUIT_Report_COSE_Sign1 .and SUIT_COSE_Profiles
suit-wg/suit-report/draft-ietf-suit-report.xml(457): Warning: Too long line found (L622), 9 characters longer than 72 characters:
   SUIT_Report_Protected /= SUIT_Report_COSE_Sign1_Tagged .and SUIT_COSE_Profiles
suit-wg/suit-report/draft-ietf-suit-report.xml(457): Warning: Too long line found (L623), 1 characters longer than 72 characters:
   SUIT_Report_Protected /= SUIT_Report_COSE_MAC0 .and SUIT_COSE_Profiles
suit-wg/suit-report/draft-ietf-suit-report.xml(457): Warning: Too long line found (L624), 8 characters longer than 72 characters:
   SUIT_Report_Protected /= SUIT_Report_COSE_MAC0_Tagged .and SUIT_COSE_Profiles
suit-wg/suit-report/draft-ietf-suit-report.xml(942): Warning: Too long line found (L1013), 2 characters longer than 72 characters:
   SUIT_Report_Protected /= SUIT_Report_COSE_Sign1 .and SUIT_COSE_Profiles
suit-wg/suit-report/draft-ietf-suit-report.xml(942): Warning: Too long line found (L1014), 9 characters longer than 72 characters:
   SUIT_Report_Protected /= SUIT_Report_COSE_Sign1_Tagged .and SUIT_COSE_Profiles
suit-wg/suit-report/draft-ietf-suit-report.xml(942): Warning: Too long line found (L1015), 1 characters longer than 72 characters:
   SUIT_Report_Protected /= SUIT_Report_COSE_MAC0 .and SUIT_COSE_Profiles
suit-wg/suit-report/draft-ietf-suit-report.xml(942): Warning: Too long line found (L1016), 8 characters longer than 72 characters:
   SUIT_Report_Protected /= SUIT_Report_COSE_MAC0_Tagged .and SUIT_COSE_Profiles
suit-wg/suit-report/draft-ietf-suit-report.xml(942): Warning: Too long line found (L1038), 7 characters longer than 72 characters:
     suit-report-records         => [ * SUIT_Record / system-property-claims ],
suit-wg/suit-report/draft-ietf-suit-report.xml(942): Warning: Too long line found (L1075), 1 characters longer than 72 characters:
     suit-component-capabilities        => [+ SUIT_Component_Capability ]

On TXT file:

  ** There are 11 instances of too long lines in the document, the longest
     one being 9 characters in excess of 72.

The line, such as,

452	     suit-component-capabilities        => [+ SUIT_Component_Capability ]

could remove the warning by changing to

452	     suit-component-capabilities        => [+ SUIT_Component_Capability]

Others, such as,

520	   SUIT_Report_Protected /= SUIT_Report_COSE_Sign1_Tagged .and SUIT_COSE_Profiles

might be better manually line wrapping it to,

520	   SUIT_Report_Protected /= \
521	       SUIT_Report_COSE_Sign1_Tagged .and SUIT_COSE_Profiles

which will not lose the readability for developers.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant