Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Harvest dimensions #214

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP] Harvest dimensions #214

wants to merge 3 commits into from

Conversation

jmartin-sul
Copy link
Member

@jmartin-sul jmartin-sul commented Mar 5, 2025

tested manually, got some publications, need to get unit tests written.

at present, this PR does bring in a few small changes that are extraneous to the original ticket. happy to cherry pick those into a separate PR if that makes review easier or if people would like the commit history more that way.

closes #162

…B, instead of ORCID -> DOI mapping from pickle file
* more context for docker compose comment
* harvest DAG: a more consistent/descriptive parameter name, and a fix for a parameter value
* in CI and in all envs, show SQLAlchemy 2.0 deprecation warnings (but outside of CI, skip showing the top level warning about how there are things in 1.4 that are deprecated for 2.0)
* log a message about the dev_limit value

return inverted_dict


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, removing code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write harvest_dimensions task
2 participants