Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS doesn't take into account GMT timezone correctly when saving task time #15

Open
Edvinas9 opened this issue Nov 2, 2017 · 2 comments

Comments

@Edvinas9
Copy link
Contributor

Edvinas9 commented Nov 2, 2017

Conditions

I've only tested this for automations within SuluArticleBundle.
Server time: GMT+0
Admin (visitor) timezone: GMT+2

Steps to reproduce

Create a new task and set time (for example 3:00 PM). Save it. In my case, since there are 2 hours difference between me and the server - I would expect that server will subtract 2 hours when saving. But it doesn't. It just saves as 2PM GMT+0.

Then, open the newly created task. You will notice that CMS is clever enough to add 2 hours (difference between visitor timezone and server timezone) to the time in field so it now appears as 4:00 PM (GMT+2). If you click save again without changing anything - CMS will save it as 4:00 PM GMT+0, not 4:00PM GMT+2.

So this is like a vicious cycle that adds/removes a few hours (+2 hours in my case) every time I click save without actually changing anything.

Expected behaviour

When saving a task, CMS should make adjustments to task time by taking into account difference between visitor/server timezones.

@mareksuscak
Copy link

We just stumbled upon the same issue. Any plans to get it resolved anytime soon? Happy to contribute a patch but I might need some pointers.

@wachterjohannes
Copy link
Member

@mareksuscak the question here is where should we handle this issue:

you can create a PR and we can discuss there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants