Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split expand in expand and overlay component #64

Open
alexander-schranz opened this issue Oct 28, 2021 · 0 comments
Open

Split expand in expand and overlay component #64

alexander-schranz opened this issue Oct 28, 2021 · 0 comments
Milestone

Comments

@alexander-schranz
Copy link
Member

Currently the expand is used for 2 usecases, overlays and things to be open or add a class to it. It is controlled currently over the closeOnEsc if it should be closed. The closeOnEsc is currently not correclty implemented when having multiple overlays open at once or a stack of overlays as this is more complex overlay and the closeOnEsc behaviour should be open moved into an own component. Another way would be moving the EscapeStack into an service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant