-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run.sh should kill any previously existing golden processes #1
Comments
Hey cool, I didn't know anyone was using this 🙂 Can you give the latest version a try? This should take care of killing off the child processes. |
I found this script on the bspwm subreddit and been using it since. Reading the stackoverflow thread it seems the If you execute You can easily try it yourself, just do I submitted a PR with my own implementation, I don't know if it's totally correct but so far it seems to work fine. Please read the commit message and see how you feel about it. |
Thanks a lot for sending this, I’ll play around with it on my own.
What’s the best way to repro through normal usage? Are you killing and
relaunching bspwm manually, or using a bspc command to do it?
On Thu, Feb 6, 2020 at 5:08 PM indeedwatson ***@***.***> wrote:
I found this script on the bspwm subreddit and been using it since.
Reading the stackoverflow thread it seems the trap part is to kill
processes once the script is exited, but there's a problem:
If you execute run.sh in bspwmrc, when you restart bspwm the process is
simply spawned again. So any child processes from the first script don't
get killed because the first script itself just keeps running.
I submitted a PR with my own implementation, I don't know if it's totally
correct but so far it seems to work fine. Please read the commit message
and see how you feel about it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AAAENJUBING3MAIJTNIMZ23RBQYX5A5CNFSM4KOSZOBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK7YX2Y#issuecomment-582978539>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAENJVMGDD34O4OU6XR2PDRBQYX5ANCNFSM4KOSZOBA>
.
--
Sumeet Agarwal
937.657.8614
|
You were quick to reply. See the edit I made:
|
Couple initial impressions:
|
If you have
run.sh
in yourbspwmrc
and you reload bspwm a new run.sh and run.py processes will start. I found myself yesterday inadvertedly with around 25run.sh
andrun.py
processes in the background, which I had to kill one by one because I didn't know how to perform akillall
on them.So
run.sh
should have a way to kill any previous process before it starts, much like you have forsxhkd
in your example.The text was updated successfully, but these errors were encountered: