Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using some float64 values with bremsstrahlung_thick_target returns all NaNs #125

Open
KriSun95 opened this issue Oct 18, 2023 · 0 comments

Comments

@KriSun95
Copy link
Collaborator

Describe the bug

Issue when using numpy.float64 numbers for the parameters in sunxspex.emission.bremsstrahlung_thick_target as it ends up returning all nans and infs. Weirdly, rounding to 15 decimal places with the values that return nans and infs fixes this.

I've "fixed" this in sunxspex.sunxspex_fitting.photon_models_for_fitting.thick_fn by taking the inputs and rounding to 15 decimal places via np.round([total_eflux, index, e_c], 15) but obviously this isn't ideal.

I will come back and add more detail when I find and log values that produce this weird behaviour but wanted it mentioned somewhere so it doesn't get lost.

To Reproduce

No response

Screenshots

No response

System Details

No response

Installation method

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant