Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out when to "start timer" #46

Closed
Lars-Codes opened this issue May 16, 2024 · 1 comment
Closed

Figure out when to "start timer" #46

Lars-Codes opened this issue May 16, 2024 · 1 comment

Comments

@Lars-Codes
Copy link
Collaborator

In server/models/printers.py, in parseGcode, we have this line:

if("M569" in line) and job.getTimeStarted()==0:
We choose this Gcode line to "start" the timer. However, this is a GCode line that is included in GCode files sliced by the Prusa Slicer specifically for MK4. If we want to expand this to more printers, we need a less hardcoded way to "start" the timer. How do we know when the printer starts extruding if this isn't a universal command?

There may be a JSON file that lists all of the GCode lines that mark first extrude. The exact lines may differ depending on both the type of 3D printer and also the specific slicer you are using. Figure out when to mark the timer start using a more universal method.

@ndg8743
Copy link
Collaborator

ndg8743 commented Dec 16, 2024

fixed with refactor, pull req #80

@ndg8743 ndg8743 closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants