Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Already have an account? Sign in" appears in places where this text doesn't make sense #254

Open
2 tasks done
kav opened this issue Feb 5, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@kav
Copy link

kav commented Feb 5, 2024

Bug report

When using Magic Links "Already have an account? Sign in" shows at the bottom of the magic link UI. This text is confusing as magic link is already a sign in mechanism for users with an account.

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

When using Magic Links "Already have an account? Sign in" shows at the bottom of the magic link UI. This text is confusing as magic link is already a sign in mechanism for users with an account.

To Reproduce

create an <Auth /> component with magicLink. Click Send a magic link email

Expected behavior

"Sign in with a password or 3rd party auth provider" or a similar message should appear by default instead. "Already have an account? Sign in" should only appear on the Sign Up page.

Note the fact that you can override this message isn't a fix it's a workaround and doesn't solve the issue that the text to return to Login from Signup should not be the same as the text to return to Login from Magic Link (or Reset Password for that matter)

Screenshots

image

Additional context

Also #191 is still an issue. By default "Already have an account? Sign in" doesn't make sense as the text to return to the login screen from the forgot password screen

@kav kav added the bug Something isn't working label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant