progress

Author: psteinroe

crates/pgt_configuration/src/analyser/linter/rules.rs

@@ -724,7 +724,7 @@ impl Safety {
     }
     pub(crate) fn severity(rule_name: &str) -> Severity {
         match rule_name {
-            "addSerialColumn" => Severity::Error,
+            "addSerialColumn" => Severity::Warning,
             "addingFieldWithDefault" => Severity::Warning,
             "addingForeignKeyConstraint" => Severity::Warning,
             "addingNotNullField" => Severity::Warning,
@@ -741,7 +741,7 @@ impl Safety {
             "constraintMissingNotValid" => Severity::Warning,
             "creatingEnum" => Severity::Warning,
             "disallowUniqueConstraint" => Severity::Error,
-            "lockTimeoutWarning" => Severity::Error,
+            "lockTimeoutWarning" => Severity::Warning,
             "multipleAlterTable" => Severity::Warning,
             "preferBigInt" => Severity::Warning,
             "preferBigintOverInt" => Severity::Warning,
@@ -755,7 +755,7 @@ impl Safety {
             "renamingTable" => Severity::Warning,
             "requireConcurrentIndexCreation" => Severity::Warning,
             "requireConcurrentIndexDeletion" => Severity::Warning,
-            "runningStatementWhileHoldingAccessExclusive" => Severity::Error,
+            "runningStatementWhileHoldingAccessExclusive" => Severity::Warning,
             "transactionNesting" => Severity::Warning,
             _ => unreachable!(),
         }

crates/pgt_lsp/tests/server.rs

@@ -1690,9 +1690,7 @@ ALTER TABLE ONLY "public"."campaign_contact_list"
                         .filter(|d| {
                             d.code.as_ref().is_none_or(|c| match c {
                                 lsp::NumberOrString::Number(_) => true,
-                                lsp::NumberOrString::String(s) => {
-                                    s != "lint/safety/addingForeignKeyConstraint"
-                                }
+                                lsp::NumberOrString::String(s) => !s.starts_with("lint/safety"),
                             })
                         })
                         .count()

docs/reference/rules/add-serial-column.md

@@ -30,7 +30,7 @@ ALTER TABLE prices ADD COLUMN id serial;
 ```sh
 code-block.sql:1:1 lint/safety/addSerialColumn ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × Adding a column with type serial requires a table rewrite.
+  ! Adding a column with type serial requires a table rewrite.
 
   > 1 │ ALTER TABLE prices ADD COLUMN id serial;
       │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -50,7 +50,7 @@ ALTER TABLE prices ADD COLUMN id bigserial;
 ```sh
 code-block.sql:1:1 lint/safety/addSerialColumn ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × Adding a column with type bigserial requires a table rewrite.
+  ! Adding a column with type bigserial requires a table rewrite.
 
   > 1 │ ALTER TABLE prices ADD COLUMN id bigserial;
       │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -70,7 +70,7 @@ ALTER TABLE prices ADD COLUMN total int GENERATED ALWAYS AS (price * quantity) S
 ```sh
 code-block.sql:1:1 lint/safety/addSerialColumn ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × Adding a column with GENERATED ALWAYS AS ... STORED requires a table rewrite.
+  ! Adding a column with GENERATED ALWAYS AS ... STORED requires a table rewrite.
 
   > 1 │ ALTER TABLE prices ADD COLUMN total int GENERATED ALWAYS AS (price * quantity) STORED;
       │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

docs/reference/rules/lock-timeout-warning.md

@@ -33,7 +33,7 @@ ALTER TABLE users ADD COLUMN email TEXT;
 ```sh
 code-block.sql:1:1 lint/safety/lockTimeoutWarning ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × Statement takes ACCESS EXCLUSIVE lock on public.users without lock timeout set.
+  ! Statement takes ACCESS EXCLUSIVE lock on public.users without lock timeout set.
 
   > 1 │ ALTER TABLE users ADD COLUMN email TEXT;
       │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -53,7 +53,7 @@ CREATE INDEX users_email_idx ON users(email);
 ```sh
 code-block.sql:1:1 lint/safety/lockTimeoutWarning ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × Statement takes SHARE lock on public.users while creating index users_email_idx without lock timeout set.
+  ! Statement takes SHARE lock on public.users while creating index users_email_idx without lock timeout set.
 
   > 1 │ CREATE INDEX users_email_idx ON users(email);
       │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^