Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Option for private API URL #6

Open
JustJarethB opened this issue Jun 19, 2019 · 2 comments
Open

Request: Option for private API URL #6

JustJarethB opened this issue Jun 19, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@JustJarethB
Copy link

The CLI and API options are convenient often but there are use cases where the CLI is not feasible and the user may not wish to use the MJML API. Perhaps we could provide our own endpoint with optional key/appId, allowing a custom/private server instead of the public server. This can:

  • lighten the load on MJML servers
  • allow for faster response if the MJML servers are busy
  • have a fallback should something happen to the API service
@sjelfull sjelfull self-assigned this Jun 20, 2019
@sjelfull sjelfull added the enhancement New feature or request label Jun 20, 2019
@sjelfull
Copy link
Member

This is a good suggestion, but you would need to implement a endpoint that matches the signature of the official API - which is non-trivial for most users.

I'm open to someone making a PR for this, but I won't touch this for now.

@jamesmacwhite
Copy link

jamesmacwhite commented Nov 20, 2024

@sjelfull Revisiting this due to the open API not having any formal SLA for production usage. While it works, this is a bit of a concern, in addition you may not be able to run the CLI on a production environment if its cloud based or PaaS. There are self hosted options out there that implement the same API with the render endpoint.

Would you be open to allowing the API endpoint to be config variable to switch out. I don't think there would be anything major to change, as the idea if any third party API implements the render endpoint the same.

E.g. https://github.com/danihodovic/mjml-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants