Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The serialization and deserialization of Query cannot be shared across different backends. #2410

Open
jieguangzhou opened this issue Aug 22, 2024 · 2 comments
Assignees
Labels
📉 technical debt Things that slow us down

Comments

@jieguangzhou
Copy link
Collaborator

jieguangzhou commented Aug 22, 2024

Currently, Query is actually divided into two types: MongoQuery and IbisQuery. When used in a MongoDB scenario, after export, it is recorded as superduper_mongodb, making it impossible to migrate to Ibis.

Our current application heavily depends on Query, which leads to a strong dependency on the backend during application construction and export, making it difficult to establish a unified application standard

#2363 (comment)

In the future, all Query classes can be merged into one class, with Query only recording the expression and being independent the type of the database.
We can use Databackend to execute the Query

@jieguangzhou jieguangzhou added the 📉 technical debt Things that slow us down label Aug 22, 2024
@blythed
Copy link
Collaborator

blythed commented Aug 23, 2024

Solution: serialize with a base function: superduper.backends.base.parse_query.

@blythed blythed self-assigned this Aug 23, 2024
@jieguangzhou
Copy link
Collaborator Author

#2417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📉 technical debt Things that slow us down
Projects
None yet
Development

No branches or pull requests

2 participants