Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @trigger("apply") instead of on_create. #2718

Open
jieguangzhou opened this issue Jan 7, 2025 · 0 comments
Open

Use @trigger("apply") instead of on_create. #2718

jieguangzhou opened this issue Jan 7, 2025 · 0 comments
Labels
📉 technical debt Things that slow us down

Comments

@jieguangzhou
Copy link
Collaborator

jieguangzhou commented Jan 7, 2025 •
edited
Loading

These two functions are the same, so we only need to keep @trigger and remove the related logic of on_create in event.py inside Create.execute, no longer reloading the component there.
@jieguangzhou jieguangzhou changed the title Use @trigger(‘apply’) instead of on_create. Use @trigger("apply") instead of on_create. Jan 7, 2025
@jieguangzhou jieguangzhou added the 📉 technical debt Things that slow us down label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📉 technical debt Things that slow us down
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jieguangzhou