Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machine restart policy on-fail should be on-failure #2844

Open
andie787 opened this issue Sep 21, 2023 · 1 comment
Open

machine restart policy on-fail should be on-failure #2844

andie787 opened this issue Sep 21, 2023 · 1 comment
Labels
bug Something isn't working good first issue good small task ux User experience

Comments

@andie787
Copy link
Contributor

The --restart flag for fly m run has on-fail as one of the options, but this should really be on-failure like it is in the Machines API and Docker's restart policy. See

flyctl/internal/command/machine/run.go

Line 791 in 51a1b8f

case "on-fail":

Since this is already in use, I'm not sure if it should be fixed or if we can alias on-fail to on-failure and update the docs.

Related:
superfly/docs#1043 (comment)
cc @jipperinbham
@andie787 andie787 added bug Something isn't working ux User experience labels Sep 21, 2023
@andie787 andie787 mentioned this issue Nov 30, 2023
Merged
@vhespanha
Copy link

Can i tak this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue good small task ux User experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andie787 @vhespanha