Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action tags don't work on web #1478

Closed
knopp opened this issue Oct 2, 2023 · 6 comments
Closed

Action tags don't work on web #1478

knopp opened this issue Oct 2, 2023 · 6 comments
Labels
area_supereditor Pertains to SuperEditor f:superlist Funded by Superlist

Comments

@knopp
Copy link
Contributor

knopp commented Oct 2, 2023

Reproducible with the example. Upon selection the document node does not change type, instead new line is inserted.

@miguelcmedeiros
Copy link
Collaborator

Cc @matthew-carroll

@miguelcmedeiros miguelcmedeiros added area_supereditor Pertains to SuperEditor f:superlist Funded by Superlist labels Oct 2, 2023
@matthew-carroll
Copy link
Contributor

This is likely related to the IME and selector work. We should check this again after #1469 is merged.

@knopp
Copy link
Contributor Author

knopp commented Oct 11, 2023

After spending some time on this I believe this needs to be fixed in Flutter. The problem is that both raw keyboard and IME are handling the DOM event, separately. The IME event subscription fires first and it invokes the text field input action regardless of whether the keyboard event has been handled by Flutter. Actually, because the event handler is registered on the text field DOM elementitself and not the window, it fires the input action even before the normal keyboard handling had chance to look at event, let alone mark it as handled.

I'll try to put together a test case and report this. I'm wondering why the window keydown handler is not registered in capturing mode the prevent the event reaching the textfield if handled.

@knopp
Copy link
Contributor Author

knopp commented Oct 12, 2023

flutter/flutter#136460

@matthew-carroll
Copy link
Contributor

@knopp do you know if this issue is now resolved, given the flutter issue was marked resolved?

@knopp
Copy link
Contributor Author

knopp commented Dec 9, 2023

It is resolved.

@knopp knopp closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area_supereditor Pertains to SuperEditor f:superlist Funded by Superlist
Projects
None yet
Development

No branches or pull requests

3 participants