Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperEditor] - Cannot linkify links that don't conform to the URL format, like app links #2427

Open
miguelcmedeiros opened this issue Nov 27, 2024 · 3 comments
Labels
area_supereditor Pertains to SuperEditor

Comments

@miguelcmedeiros
Copy link
Collaborator

Currenlty if a user types an app link for Obsidian (e.g. obsidian://open?vault=98_Obsidian_NEW_2023&file=30-) followed by a space, it will not get linkified.

LinkifyReaction uses linkify to detect URLs in order to linkify text and it uses the 2 default linkifiers: UrlLinkifier and EmailLinkifier.

These do not cover the cases like app links to apps like Obsidian where the link does not conform to the URL format.

@miguelcmedeiros miguelcmedeiros added the area_supereditor Pertains to SuperEditor label Nov 27, 2024
@miguelcmedeiros
Copy link
Collaborator Author

Cc @matthew-carroll

@matthew-carroll
Copy link
Contributor

@miguelcmedeiros is the idea that we should identify any string that has a "://" that separates two pieces of text? Or do we expect the user to specify each application scheme that should be recognized?

@miguelcmedeiros
Copy link
Collaborator Author

@matthew-carroll

is the idea that we should identify any string that has a "://" that separates two pieces of text?

That makes sense, since it should parse the URL string into a URI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area_supereditor Pertains to SuperEditor
Projects
None yet
Development

No branches or pull requests

2 participants