Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperEditor][SuperReader] - Minimize uses of node indices #2434

Closed
matthew-carroll opened this issue Nov 30, 2024 · 0 comments · Fixed by #2435
Closed

[SuperEditor][SuperReader] - Minimize uses of node indices #2434

matthew-carroll opened this issue Nov 30, 2024 · 0 comments · Fixed by #2435
Assignees
Labels

Comments

@matthew-carroll
Copy link
Contributor

When we change a Document from a list of nodes to a tree of nodes (#2433) the concept of a "node index" will change in a significant way. There will no longer be a global node index. Instead, a node will have an index within some parent node. The root node will be called the "document".

To prepare us for this change, convert every unnecessary use of node indices to some other node access mechanism, such that we can use the same access mechanism with a tree. For example, I expect that we'll retain getNodeById() at a document level, which means those uses won't be impacted by the change to a tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant