Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] fetchResponse in function return signatures should be optional #46

Open
nkshah2 opened this issue Jun 23, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@nkshah2
Copy link
Contributor

nkshah2 commented Jun 23, 2022

Each recipe function that makes a network call has a fetchResponse in its return signature which contains the original response object.

The problem this causes is that if the function is overridden and the logic is changed to not make a network call, you are forced to pass new Response() when returning. This is a bad interface to have any making the fetchResponse optional will solve this.

@nkshah2 nkshah2 added the enhancement New feature or request label Jun 23, 2022
@nkshah2 nkshah2 self-assigned this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant