Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified "self-referencing" for functions in a structure #4

Open
AlanCxxx opened this issue Oct 15, 2019 · 1 comment
Open

Simplified "self-referencing" for functions in a structure #4

AlanCxxx opened this issue Oct 15, 2019 · 1 comment

Comments

@AlanCxxx
Copy link

I really appreciate your work. I am using it to build an 8085 emulator of my CP/M project.
Two minor issue you may want to look at:

  1. A simplified way of using "self-referencing" functions in a structure. Have a look at my version of your header file.
    i8085_h.txt

  2. Pretty minor but the 8080 interrupt can handle one, two and three byte opcodes. Your code only allows a single byte opcode.

@superzazu
Copy link
Owner

Hello,

About your first point; the idea of "userdata" is not to have a self-referencing pointer: the user may want to pass a pointer to another structure ; see https://github.com/superzazu/invaders/blob/master/invaders.c#L241 for a practical example.

Thank you for pointing out the problem about interrupts, it is indeed something I will have to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants